Bugreport: OnHit Effects stacking with Objects on a tile

Discussion in 'Bugs' started by dE, Jul 20, 2011.

  1. dE

    dE Member

    This is a fairly simple bug, it also seems to be at the root of several problems. So here's the bugreport for this.


    Bug: OnHit Effects multiply with tile objects
    Reproducable: Yes, see below

    Description: If there is more than one targetable object resting on a tile, let's say there's an enemy standing on a corpse, OnHit Effects will apply to both. This stacks with the amount of objects on that tile. Extreme example, if you're using a narrow hallway to clear out a zoo, this can lead to up to 50+ corpses on a single tile, with OnHit Effects being applied to all of them.

    What does it do:
    In the most simple case, it does cause increasing lag with each attack, when there's more than one targetable object on a tile. To Hit, Damage and Skill Procs will also be calculated for every object on that tile. With Skills like Sneaky Shiv or Lichtenauer Overhau, this quickly multiplies out of hand.

    Why is this a problem:
    For most skills, this is only a performance issue/potential crash issue, since you can't make something inanimate any more inanimate, but this also breaks Vampirism (which also triggers for all those objects) and Thor's Fulminaric Bolt (which will be cast again for every object as well). It probably breaks other targeted spells too, I however didn't check all of them.

    How to reproduce:
    Kill an enemy, lure another enemy onto the same tile, use a targeted spell with an animation; see them trigger several times.

    If this has been posted before, I'm sorry.